chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java - Issue 2124583003: Replace Shared Prefs commit with apply.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java

Issue 2124583003: Replace Shared Prefs commit with apply. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix merge conflict. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackupIntegrationTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java

index ec3401d9a8e688d036ff47d29dd0448afa93b917..8c5f3a016ef7e1c5e1a7a87938055c4345e67c3f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java

@@ -133,6 +133,10 @@ public class ManageSpaceActivity extends AppCompatActivity implements View.OnCli

return;

}

+ // If the native library crashes and kills the browser process, there is no guarantee

+ // java-side the pref will be written before the process dies. We want to make sure we

+ // don't attempt to start the browser process and have it kill chrome. This activity is

+ // used to clear data for the chrome app, so it must be particularly error resistant.

ContextUtils.getAppSharedPreferences().edit()

.putString(PREF_FAILED_BUILD_VERSION, productVersion)

.commit();