Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.h

Issue 2124583002: Consider 'order' when updating feConvolveMatrix 'target*' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.h
diff --git a/third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.h b/third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.h
index 41393fd898dd54a50c5ae103c95c3889e0a888c3..ba5f4d34deedb293de460f28c8fdb8a7fb429bee 100644
--- a/third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.h
+++ b/third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.h
@@ -48,8 +48,8 @@ public:
SVGAnimatedNumberList* kernelMatrix() { return m_kernelMatrix.get(); }
SVGAnimatedString* in1() { return m_in1.get(); }
SVGAnimatedEnumeration<EdgeModeType>* edgeMode() { return m_edgeMode.get(); }
- SVGAnimatedInteger* orderX() { return m_order->firstInteger(); }
- SVGAnimatedInteger* orderY() { return m_order->secondInteger(); }
+ SVGAnimatedInteger* orderX() const { return m_order->firstInteger(); }
+ SVGAnimatedInteger* orderY() const { return m_order->secondInteger(); }
SVGAnimatedInteger* targetX() { return m_targetX.get(); }
SVGAnimatedInteger* targetY() { return m_targetY.get(); }
@@ -58,6 +58,9 @@ public:
private:
explicit SVGFEConvolveMatrixElement(Document&);
+ IntSize matrixOrder() const;
+ IntPoint targetPoint() const;
+
bool setFilterEffectAttribute(FilterEffect*, const QualifiedName&) override;
void svgAttributeChanged(const QualifiedName&) override;
FilterEffect* build(SVGFilterBuilder*, Filter*) override;

Powered by Google App Engine
This is Rietveld 408576698