Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2692)

Unified Diff: components/omnibox/browser/verbatim_match.h

Issue 2124563002: Don't try to create a verbatim match with an empty input. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/verbatim_match.h
diff --git a/components/omnibox/browser/verbatim_match.h b/components/omnibox/browser/verbatim_match.h
index 05573b15d4715da0cae1a2d59f88fe848193ec79..9b4f0b6c2b2edc1aadac1905db7325fef2ead973 100644
--- a/components/omnibox/browser/verbatim_match.h
+++ b/components/omnibox/browser/verbatim_match.h
@@ -15,9 +15,10 @@ class HistoryURLProvider;
// Returns a verbatim match for input.text() with a relevance of
// |verbatim_relevance|. If |verbatim_relevance| is negative then a default
-// value is used. If the desired |destination_url| is already known and a
+// value is used. If the desired |destination_url| is already known and a
// |history_url_provider| is also provided, this may be more efficient (see
// implementation for details) than the default code path.
+// input.text() must not be empty.
AutocompleteMatch VerbatimMatchForURL(
AutocompleteProviderClient* client,
const AutocompleteInput& input,

Powered by Google App Engine
This is Rietveld 408576698