chrome/android/webapk/shell_apk/BUILD.gn - Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/shell_apk/BUILD.gn

Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java ('K') | « chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java ('k') | chrome/browser/android/chrome_jni_registrar.cc » ('j') | chrome/browser/android/webapk/manifest_upgrade_detector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/webapk/shell_apk/BUILD.gn

diff --git a/chrome/android/webapk/shell_apk/BUILD.gn b/chrome/android/webapk/shell_apk/BUILD.gn

index c15b38c25a814c91579b551dbfb4851ac84dedb7..f67165401f5842c0297a0475a881b78f4eaae5e7 100644

--- a/chrome/android/webapk/shell_apk/BUILD.gn

+++ b/chrome/android/webapk/shell_apk/BUILD.gn

@@ -22,8 +22,8 @@ declare_args() {

webapk_scope_url = "https://www.template.com"

webapk_display_mode = "standalone"

webapk_orientation = "portrait"

- webapk_theme_color = "4288230399L" #0xFF9933FF

- webapk_background_color = "4291624959L" #0xFFCCFFFF

+ webapk_theme_color = "2147483648L" # HostBrowserLauncher#MANIFEST_COLOR_INVALID_OR_MISSING

+ webapk_background_color = "2147483648L" #HostBrowserLauncher#MANIFEST_COLOR_INVALID_OR_MISSING

# The URL of the app icon. Empty if the app icon is generated.

webapk_icon_url = "http://www.template.com/icon.png"