chrome/chrome_browser.gypi - Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Get start_url from WebAPK's metadata and nits. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/webapk/manifest_upgrade_detector.cc ('K') | « chrome/browser/android/webapk/manifest_upgrade_detector.cc ('k') | chrome/test/data/webapps/manifest_test_page_test_start_url_change.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 861a281922fd0dc3e67ad7fae53426cbab817617..9fadec4d82f785b7afe60b1ba04111045f8c3f0b 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -829,12 +829,12 @@

'browser/android/download/chrome_download_delegate.h',

'browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc',

'browser/android/download/chrome_download_manager_overwrite_infobar_delegate.h',

- 'browser/android/download/download_manager_service.cc',

- 'browser/android/download/download_manager_service.h',

'browser/android/download/download_controller.cc',

'browser/android/download/download_controller.h',

'browser/android/download/download_controller_base.cc',

'browser/android/download/download_controller_base.h',

+ 'browser/android/download/download_manager_service.cc',

+ 'browser/android/download/download_manager_service.h',

'browser/android/download/download_overwrite_infobar_delegate.cc',

'browser/android/download/download_overwrite_infobar_delegate.h',

'browser/android/download/mock_download_controller.cc',

@@ -994,6 +994,8 @@

'browser/android/warmup_manager.h',

'browser/android/web_contents_factory.cc',

'browser/android/web_contents_factory.h',

+ 'browser/android/webapk/manifest_upgrade_detector.cc',

+ 'browser/android/webapk/manifest_upgrade_detector.h',

'browser/android/webapps/add_to_homescreen_data_fetcher.cc',

'browser/android/webapps/add_to_homescreen_data_fetcher.h',

'browser/android/webapps/add_to_homescreen_dialog_helper.cc',

@@ -2106,6 +2108,7 @@

'android/java/src/org/chromium/chrome/browser/ssl/SecurityStateModel.java',

'android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModel.java',

'android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java',

+ 'android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java',

'android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java',

'chrome_browser_mdns_sources': [