chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java - Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Introduce manifest upgrade detector. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

index ac731f266fff484a13e769312a7b4ff636d7ed78..a5fbffe03d4ed10b865e020abc8f318063a5e43f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java

@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.tab;

import org.chromium.chrome.browser.banners.AppBannerManager;

import org.chromium.chrome.browser.contextmenu.ChromeContextMenuPopulator;

import org.chromium.chrome.browser.contextmenu.ContextMenuPopulator;

+import org.chromium.chrome.browser.webapps.ManifestUpgradeDetector;

import org.chromium.components.navigation_interception.InterceptNavigationDelegate;

import org.chromium.components.web_contents_delegate_android.WebContentsDelegateAndroid;

@@ -51,6 +52,10 @@ public class TabDelegateFactory {

return new AppBannerManager(tab, tab.getApplicationContext());

}

+ public ManifestUpgradeDetector createManifestUpgradeDetector(Tab tab) {

+ return null;

+ }

/**

* Creates the {@link TopControlsVisibilityDelegate} the tab will be initialized with.

* @param tab The associated {@link Tab}.