chrome/test/data/webapps/manifest_test_page_test_start_url_change.html - Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/webapps/manifest_test_page_test_start_url_change.html

Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <html>	1 <html>
	pkotwicz 2016/07/25 17:35:53 It should be possible to delete this file now? It should be possible to delete this file now? Xi Han 2016/07/25 20:01:38 I am afraid not, the test testStartUrlChangeShould Show quoted text On 2016/07/25 17:35:53, pkotwicz wrote: > It should be possible to delete this file now? I am afraid not, the test testStartUrlChangeShouldReturnUpgradeTrue needs to load this URL. pkotwicz 2016/07/25 22:32:08 You are right. You need the test page for your tes You are right. You need the test page for your test.
2 <head>	2 <head>

3 <title>Web app banner test page</title>	3 <title>Web manifest upgrade detector test page</title>

4 <link rel="manifest" href="manifest.json" />	4 <link rel="manifest" href="manifest.json" />

5 </head>	5 </head>

6 <body>	6 <body>

7 Do-nothing page with a manifest.	7 Do-nothing page with a manifest.

8 </body>	8 </body>

9 </html>	9 </html>

OLD	NEW

« chrome/browser/android/webapk/manifest_upgrade_detector.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »