chrome/browser/android/webapk/manifest_upgrade_detector_unittest.cc - Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/webapk/manifest_upgrade_detector_unittest.cc

Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/android/webapk/manifest_upgrade_detector.cc ('K') | « chrome/browser/android/webapk/manifest_upgrade_detector.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/test/data/webapps/manifest_test_page_test_start_url_change.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/android/webapk/manifest_upgrade_detector.h"

	6 #include "content/public/common/manifest.h"

	7 #include "testing/gtest/include/gtest/gtest.h"

	8

	9 using ManifestUpgradeDetectorTest = testing::Test;

	10

	11 TEST_F(ManifestUpgradeDetectorTest,

	12 OnDidGetManifestReturnsFalseWhenTheFetchedManifestUrlIsEmpty) {

	13 ManifestUpgradeDetector detector(nullptr, jobject(), nullptr, GURL(), GURL());

	14 EXPECT_EQ(ManifestUpgradeDetector::NoErrorDetected, detector.error_code());

	15

	16 content::Manifest manifest;

	17 detector.OnDidGetManifest(GURL(), manifest);

	18 EXPECT_EQ(ManifestUpgradeDetector::FetchedManifestEmpty,

	19 detector.error_code());

	20 }

OLD	NEW