Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2124443002: Add type test for jsinterop types. (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -0 lines) Patch
A tests/compiler/dart2js/jsinterop/world_test.dart View 1 1 chunk +161 lines, -0 lines 0 comments Download
A tests/html/js_typed_interop_type_test.dart View 1 1 chunk +157 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-07-04 10:34:34 UTC) #2
Jacob
lgtm
4 years, 5 months ago (2016-07-06 16:32:00 UTC) #3
Johnni Winther
4 years, 5 months ago (2016-07-08 09:57:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f2d1dba0dbfb9eca2437ec752968a778ec52ec59 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698