Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2124413002: When in-body incremantal resolution is performed, it should update REFERENCED_NAMES. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When in-body incremantal resolution is performed, it should update REFERENCED_NAMES. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/95fc17077b93585fae8404b1c78894d68d8d6c40

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add test for removing a reference. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 3 chunks +19 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 5 months ago (2016-07-07 20:48:44 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2124413002/diff/1/pkg/analyzer/test/src/context/context_test.dart File pkg/analyzer/test/src/context/context_test.dart (right): https://codereview.chromium.org/2124413002/diff/1/pkg/analyzer/test/src/context/context_test.dart#newcode3106 pkg/analyzer/test/src/context/context_test.dart:3106: void test_sequence_inBodyChange_deltaChange() { This will test that the ...
4 years, 5 months ago (2016-07-07 20:58:41 UTC) #2
scheglov
https://codereview.chromium.org/2124413002/diff/1/pkg/analyzer/test/src/context/context_test.dart File pkg/analyzer/test/src/context/context_test.dart (right): https://codereview.chromium.org/2124413002/diff/1/pkg/analyzer/test/src/context/context_test.dart#newcode3106 pkg/analyzer/test/src/context/context_test.dart:3106: void test_sequence_inBodyChange_deltaChange() { On 2016/07/07 20:58:41, Brian Wilkerson wrote: ...
4 years, 5 months ago (2016-07-07 21:02:45 UTC) #3
scheglov
4 years, 5 months ago (2016-07-07 21:04:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
95fc17077b93585fae8404b1c78894d68d8d6c40 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698