Issue 21244003: MIPS: Fix flaky mjsunit/harmony/generators-iteration test failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21244003: MIPS: Fix flaky mjsunit/harmony/generators-iteration test failure. (Closed)

Created:
7 years, 4 months ago by palfia

Modified:
7 years, 4 months ago

Reviewers:
kisg, Paul Lind, wingo, kilvadyb, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Fix flaky mjsunit/harmony/generators-iteration test failure. This fixes the result allocation in EmitCreateIteratorResult, when a GC is required. The Runtime call returns the allocated pointer in v0 register, but the rest of the function was expected it in a0 register. Refactored the function to use v0 for the result in the whole function. BUG= Committed: https://code.google.com/p/v8/source/detail?r=15965

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	src/mips/full-codegen-mips.cc	View		2 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed manually as r15965 (presubmit successful).

Expand Messages | Collapse Messages