ImageCapture: Implement focus mode for Android and Fake Video Capture Devices

ImageCapture: Implement focus mode for Android and Fake Video Capture Devices

This CL extends the PhotoCapabilities.idl to have
support for |focusMode|, and wires it down to the
three current implementations: Fake and Android
VideoCaptureDevices in browser.

This forces adding file
modules/imagecapture/PhotoCapabilities.cpp.

FocusMode is defined here:
https://w3c.github.io/mediacapture-image/index.html#idl-def-FocusMode

BUG=518807
Committed: https://crrev.com/71d68be150e06917c61429a2f63ee6793e1c2e8c
Cr-Commit-Position: refs/heads/master@{#405414}

[mcasas, 2016-07-08 23:04:43]

Description was changed from

==========
[WIP]ImageCapture: Implement focus mode for Android and Fake Video Capture
Devices

BUG=518807
==========

to

==========
ImageCapture: Implement focus mode for Android and Fake Video Capture Devices

This CL extends the PhotoCapabilities.idl to have
support for |focusMode|, and wires it down to the
three current implementations: Fake and Android
VideoCaptureDevices in browser.

This forces adding file
modules/imagecapture/PhotoCapabilities.cpp.

FocusMode is defined here:
https://w3c.github.io/mediacapture-image/index.html#idl-def-FocusMode

BUG=518807
==========

[mcasas, 2016-07-08 23:07:31]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org

[mcasas, 2016-07-08 23:07:31]

reillyg@ PTAL

[Reilly Grant (use Gerrit), 2016-07-09 00:06:31]

https://codereview.chromium.org/2124363003/diff/1/media/capture/video/android...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
(right):

https://codereview.chromium.org/2124363003/diff/1/media/capture/video/android...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:578:
|| (focusMode == CameraMetadata.CONTROL_AF_MODE_EDOF);
It seems to me that EDOF is also an autofocus mode.

https://codereview.chromium.org/2124363003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h (right):

https://codereview.chromium.org/2124363003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h:19: enum
FocusMode { Unavailable, Auto, Manual };
Just use the Mojo enum.

[mcasas, 2016-07-09 01:45:59]

https://codereview.chromium.org/2124363003/diff/1/media/capture/video/android...
File
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
(right):

https://codereview.chromium.org/2124363003/diff/1/media/capture/video/android...
media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:578:
|| (focusMode == CameraMetadata.CONTROL_AF_MODE_EDOF);
On 2016/07/09 00:06:31, Reilly Grant wrote:
> It seems to me that EDOF is also an autofocus mode.

The documentation says [1]:
"Extended depth of field (EDOF). Focusing is done digitally and continuously.
Applications should not call autoFocus(AutoFocusCallback) in this mode."

and I took the don't-call-autoFocus() as the
criteria to call a mode "manual".

[1]
https://developer.android.com/reference/android/hardware/Camera.Parameters.ht...

https://codereview.chromium.org/2124363003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h (right):

https://codereview.chromium.org/2124363003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h:19: enum
FocusMode { Unavailable, Auto, Manual };
On 2016/07/09 00:06:31, Reilly Grant wrote:
> Just use the Mojo enum.

Nice! Done.

[Reilly Grant (use Gerrit), 2016-07-11 18:21:51]

lgtm with nit

https://codereview.chromium.org/2124363003/diff/20001/media/capture/video/and...
File
media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java
(right):

https://codereview.chromium.org/2124363003/diff/20001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java:39:
@CalledByNative
nit: space between functions

[mcasas, 2016-07-11 22:42:34]

mcasas@chromium.org changed reviewers:
+ dcheng@chromium.org

[mcasas, 2016-07-11 22:42:34]

dcheng@ PTAL

(notwithstanding reillyg@s nit)

[dcheng, 2016-07-12 04:24:59]

https://codereview.chromium.org/2124363003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h (right):

https://codereview.chromium.org/2124363003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h:35:
media::mojom::blink::FocusMode m_focusMode;
Does the new field need to be initialized somewhere?

[mcasas, 2016-07-12 15:32:11]

mcasas@chromium.org changed reviewers:
+ foolip@chromium.org

[mcasas, 2016-07-12 15:32:12]

dcheng@ PTAL

foolip@ RS Source/modules changes plz

https://codereview.chromium.org/2124363003/diff/20001/media/capture/video/and...
File
media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java
(right):

https://codereview.chromium.org/2124363003/diff/20001/media/capture/video/and...
media/capture/video/android/java/src/org/chromium/media/PhotoCapabilities.java:39:
@CalledByNative
On 2016/07/11 18:21:51, Reilly Grant wrote:
> nit: space between functions

Done.

https://codereview.chromium.org/2124363003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h (right):

https://codereview.chromium.org/2124363003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h:35:
media::mojom::blink::FocusMode m_focusMode;
On 2016/07/12 04:24:59, dcheng wrote:
> Does the new field need to be initialized somewhere?

Done.

[dcheng, 2016-07-13 14:05:19]

mojom lgtm

[mcasas, 2016-07-13 16:03:48]

mcasas@chromium.org changed reviewers:
+ haraken@chromium.org

[mcasas, 2016-07-13 16:03:48]

haraken@ RS WebKit/Source/modules/imagecapture/* please

[haraken, 2016-07-13 23:53:26]

On 2016/07/13 16:03:48, mcasas wrote:
> haraken@ RS WebKit/Source/modules/imagecapture/* please

LGTM

[mcasas, 2016-07-14 00:05:48]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-07-14 00:05:48]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2124363003/#ps40001
(title: "reillyg@s nit, dcheng@ comment and updated
webexposed/global-interface-listing-expected.txt")

[commit-bot: I haz the power, 2016-07-14 00:07:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 02:45:10]

Description was changed from

==========
ImageCapture: Implement focus mode for Android and Fake Video Capture Devices

This CL extends the PhotoCapabilities.idl to have
support for |focusMode|, and wires it down to the
three current implementations: Fake and Android
VideoCaptureDevices in browser.

This forces adding file
modules/imagecapture/PhotoCapabilities.cpp.

FocusMode is defined here:
https://w3c.github.io/mediacapture-image/index.html#idl-def-FocusMode

BUG=518807
==========

to

==========
ImageCapture: Implement focus mode for Android and Fake Video Capture Devices

This CL extends the PhotoCapabilities.idl to have
support for |focusMode|, and wires it down to the
three current implementations: Fake and Android
VideoCaptureDevices in browser.

This forces adding file
modules/imagecapture/PhotoCapabilities.cpp.

FocusMode is defined here:
https://w3c.github.io/mediacapture-image/index.html#idl-def-FocusMode

BUG=518807
==========

[commit-bot: I haz the power, 2016-07-14 02:45:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-14 02:45:14]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 02:48:24]

Description was changed from

==========
ImageCapture: Implement focus mode for Android and Fake Video Capture Devices

This CL extends the PhotoCapabilities.idl to have
support for |focusMode|, and wires it down to the
three current implementations: Fake and Android
VideoCaptureDevices in browser.

This forces adding file
modules/imagecapture/PhotoCapabilities.cpp.

FocusMode is defined here:
https://w3c.github.io/mediacapture-image/index.html#idl-def-FocusMode

BUG=518807
==========

to

==========
ImageCapture: Implement focus mode for Android and Fake Video Capture Devices

This CL extends the PhotoCapabilities.idl to have
support for |focusMode|, and wires it down to the
three current implementations: Fake and Android
VideoCaptureDevices in browser.

This forces adding file
modules/imagecapture/PhotoCapabilities.cpp.

FocusMode is defined here:
https://w3c.github.io/mediacapture-image/index.html#idl-def-FocusMode

BUG=518807

Committed: https://crrev.com/71d68be150e06917c61429a2f63ee6793e1c2e8c
Cr-Commit-Position: refs/heads/master@{#405414}
==========

[commit-bot: I haz the power, 2016-07-14 02:48:25]

Patchset 3 (id:??) landed as
https://crrev.com/71d68be150e06917c61429a2f63ee6793e1c2e8c
Cr-Commit-Position: refs/heads/master@{#405414}