Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2124363002: Remove duplicate condition in CompositedLayerMapping::computeInterestRect(). (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate condition in CompositedLayerMapping::computeInterestRect(). BUG=626404 Committed: https://crrev.com/969a37dbd59256d636d6a061c265686d314769b4 Cr-Commit-Position: refs/heads/master@{#404326}

Patch Set 1 #

Patch Set 2 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
Xianzhu
4 years, 5 months ago (2016-07-07 18:55:32 UTC) #2
chrishtr
lgtm
4 years, 5 months ago (2016-07-07 20:03:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124363002/20001
4 years, 5 months ago (2016-07-07 20:04:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/251697)
4 years, 5 months ago (2016-07-07 22:15:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124363002/20001
4 years, 5 months ago (2016-07-07 22:17:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/251806)
4 years, 5 months ago (2016-07-08 01:05:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124363002/20001
4 years, 5 months ago (2016-07-08 02:00:08 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 09:35:53 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 09:36:19 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 09:38:25 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/969a37dbd59256d636d6a061c265686d314769b4
Cr-Commit-Position: refs/heads/master@{#404326}

Powered by Google App Engine
This is Rietveld 408576698