components/signin/core/browser/signin_metrics.h - Issue 2124343002: [Autofill] Implement Credit Card Signin Promo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/signin_metrics.h

Issue 2124343002: [Autofill] Implement Credit Card Signin Promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ifdef Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/signin_metrics.h

diff --git a/components/signin/core/browser/signin_metrics.h b/components/signin/core/browser/signin_metrics.h

index f0de9c02a88212f051986f2caaa99e04d5eb9549..a83851cf7f1c6a7b897c4b559fca975b41cee6c3 100644

--- a/components/signin/core/browser/signin_metrics.h

+++ b/components/signin/core/browser/signin_metrics.h

@@ -138,7 +138,8 @@ enum class AccessPoint : int {

ACCESS_POINT_RECENT_TABS,

ACCESS_POINT_UNKNOWN, // This should never have been used to get signin URL.

ACCESS_POINT_PASSWORD_BUBBLE,

- ACCESS_POINT_MAX, // This must be last.

+ ACCESS_POINT_AUTOFILL_DROPDOWN,

Evan Stade 2016/07/08 17:34:59 don't you need to add this to the SigninAccessPoin

Mathieu 2016/07/08 18:10:02 Done.

+ ACCESS_POINT_MAX, // This must be last.

};

// Enum values which enumerates all reasons to start sign in process.