[Autofill] Implement Credit Card Signin Promo

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 254 matching lines @@
       autofill_field->Type().GetStorableType() != CREDIT_CARD_NUMBER) {
     return false;
   }
 
   static const int kShowScanCreditCardMaxValueLength = 6;
   return field.value.size() <= kShowScanCreditCardMaxValueLength &&
          base::ContainsOnlyChars(CreditCard::StripSeparators(field.value),
                                  base::ASCIIToUTF16("0123456789"));
 }
 
+bool AutofillManager::ShouldShowCreditCardSigninPromo(
+    const FormData& form,
+    const FormFieldData& field) {
+  // Check whether we are dealing with a credit card field.
+  AutofillField* autofill_field = GetAutofillField(form, field);
+  if (!autofill_field || autofill_field->Type().group() != CREDIT_CARD) {

[Evan Stade, 2016/07/08 17:34:58]

nit: return autofill_field && autofill_field->Type().group() == CREDIT_CARD &&
client_->ShouldShowSigninPromo();

[Mathieu, 2016/07/08 18:10:02]

Neater thanks

+    return false;
+  }
+
+  // Will check if the user is signed in and if it's appropriate to show the
+  // promo (e.g. the platform is supported).
+  return client_->ShouldShowSigninPromo();
+}
+
 void AutofillManager::OnFormsSeen(const std::vector<FormData>& forms,
                                   const TimeTicks& timestamp) {
   if (!IsValidFormDataVector(forms))
     return;
 
   if (!driver_->RendererIsAvailable())
     return;
 
   bool enabled = IsAutofillEnabled();
   if (!has_logged_autofill_enabled_) {
@@ skipping 1731 matching lines @@
     if (i > 0)
       fputs("Next oldest form:\n", file);
   }
   fputs("\n", file);
 
   fclose(file);
 }
 #endif  // ENABLE_FORM_DEBUG_DUMP
 
 }  // namespace autofill