Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2124333002: Revert of [perf] Enable non-verbose logging in memory system health benchmarks (Closed)

Created:
4 years, 5 months ago by Rick Byers
Modified:
4 years, 5 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [perf] Enable non-verbose logging in memory system health benchmarks (patchset #3 id:60001 of https://codereview.chromium.org/2094143005/ ) Reason for revert: Seeing system_health.memory_desktop failures on Windows. petrcermak@ says this CL is the likely culprit and should be reverted. https://bugs.chromium.org/p/chromium/issues/detail?id=625172 Original issue's description: > [perf] Enable non-verbose logging in memory system health benchmarks > > Rationale: To help triage flakes on the perf waterfall. > > BUG=623058 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq > > Committed: https://crrev.com/a29030040dff42fe4dc0317d81f49bdaf80f1185 > Cr-Commit-Position: refs/heads/master@{#402784} TBR=nednguyen@google.com,perezju@chromium.org,primiano@chromium.org,petrcermak@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623058 Committed: https://crrev.com/5f24850ea0b9b4b4a8573c97f11758507e22ebde Cr-Commit-Position: refs/heads/master@{#404174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tools/perf/benchmarks/system_health.py View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Rick Byers
Created Revert of [perf] Enable non-verbose logging in memory system health benchmarks
4 years, 5 months ago (2016-07-07 14:54:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124333002/1
4 years, 5 months ago (2016-07-07 14:54:29 UTC) #3
petrcermak
lgtm
4 years, 5 months ago (2016-07-07 14:56:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 17:44:33 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 17:45:11 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 17:47:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f24850ea0b9b4b4a8573c97f11758507e22ebde
Cr-Commit-Position: refs/heads/master@{#404174}

Powered by Google App Engine
This is Rietveld 408576698