Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 212433004: Add a UseCounter for the webkitallowfullscreen attribute (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
Reviewers:
falken, tkent, eseidel
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Visibility:
Public.

Description

Add a UseCounter for the webkitallowfullscreen attribute We support the unprefixed allowfullscreen attribute, so it would be nice to also reflect it in HTMLIFrameElement.allowFullscreen. However, that's tricky while there are two backing attributes, so first measure if the prefixed attribute can be removed yet. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170124

Patch Set 1 #

Total comments: 2

Patch Set 2 : fullscreenIsAllowedForAllOwners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M Source/core/dom/FullscreenElementStack.cpp View 1 4 chunks +11 lines, -6 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
philipj_slow
falken, can you PTAL? eseidel, can you be falken's rubberstamp?
6 years, 9 months ago (2014-03-26 11:42:38 UTC) #1
falken
lgtm with a comment https://codereview.chromium.org/212433004/diff/1/Source/core/dom/FullscreenElementStack.cpp File Source/core/dom/FullscreenElementStack.cpp (right): https://codereview.chromium.org/212433004/diff/1/Source/core/dom/FullscreenElementStack.cpp#newcode49 Source/core/dom/FullscreenElementStack.cpp:49: static bool allowFullscreenOnAllOwners(const Document& document) ...
6 years, 9 months ago (2014-03-26 13:59:31 UTC) #2
philipj_slow
https://codereview.chromium.org/212433004/diff/1/Source/core/dom/FullscreenElementStack.cpp File Source/core/dom/FullscreenElementStack.cpp (right): https://codereview.chromium.org/212433004/diff/1/Source/core/dom/FullscreenElementStack.cpp#newcode49 Source/core/dom/FullscreenElementStack.cpp:49: static bool allowFullscreenOnAllOwners(const Document& document) On 2014/03/26 13:59:32, falken ...
6 years, 9 months ago (2014-03-26 16:18:57 UTC) #3
philipj_slow
tkent, can you rubberstamp this?
6 years, 9 months ago (2014-03-27 01:34:44 UTC) #4
tkent
lgtm
6 years, 9 months ago (2014-03-27 01:45:43 UTC) #5
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-27 01:52:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/212433004/80001
6 years, 9 months ago (2014-03-27 01:52:48 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 01:56:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 01:56:09 UTC) #9
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-27 02:00:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/212433004/80001
6 years, 9 months ago (2014-03-27 02:00:38 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 02:57:18 UTC) #12
Message was sent while issue was closed.
Change committed as 170124

Powered by Google App Engine
This is Rietveld 408576698