Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2124273004: Add hook to run remove_stale_pyc_files for WebKit/Tools/Scripts. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add hook to run remove_stale_pyc_files for WebKit/Tools/Scripts. I believe that this will clear unwanted pyc files when `gclient sync` is run, which may prevent people from hitting http://crbug.com/625877. I tested this by adding a bogus pyc file to WebKit/Tools/Scripts and running gclient sync, which deleted it. BUG=625877 Committed: https://crrev.com/dfda207ba80f0a5989c727e0b9ed08bb918db72f Cr-Commit-Position: refs/heads/master@{#404363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M DEPS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
qyearsley
4 years, 5 months ago (2016-07-07 18:39:10 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124273004/1
4 years, 5 months ago (2016-07-07 23:29:01 UTC) #7
qyearsley
Does this change look OK?
4 years, 5 months ago (2016-07-07 23:30:52 UTC) #8
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-07 23:39:33 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-08 01:06:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124273004/1
4 years, 5 months ago (2016-07-08 02:36:33 UTC) #13
mlamouri (slow - plz ping)
lgtm \o/
4 years, 5 months ago (2016-07-08 10:42:06 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 14:16:27 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 14:16:47 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:18:01 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfda207ba80f0a5989c727e0b9ed08bb918db72f
Cr-Commit-Position: refs/heads/master@{#404363}

Powered by Google App Engine
This is Rietveld 408576698