Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2124263002: [gn] Switch gcc bots to gn (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@ng58
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch gcc bots to gn BUG=chromium:474921 Committed: https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393 Cr-Commit-Position: refs/heads/master@{#37580}

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M infra/mb/mb_config.pyl View 1 2 4 chunks +7 lines, -7 lines 0 comments Download

Depends on Patchset:

Issue 2130723002 Patch 40001

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124263002/1
4 years, 5 months ago (2016-07-07 08:49:30 UTC) #4
Michael Achenbach
PTAL. Flags after the sysroot and is_clang fix: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/7405/steps/compare%20build%20flags%20%28fyi%29/logs/stdio
4 years, 5 months ago (2016-07-07 09:49:15 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124263002/40001
4 years, 5 months ago (2016-07-07 09:51:46 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 10:23:30 UTC) #9
vogelheim
lgtm
4 years, 5 months ago (2016-07-07 10:57:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124263002/40001
4 years, 5 months ago (2016-07-07 11:15:09 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-07 11:17:11 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393 Cr-Commit-Position: refs/heads/master@{#37580}
4 years, 5 months ago (2016-07-07 11:17:26 UTC) #16
Michael Achenbach
4 years, 5 months ago (2016-07-08 09:34:22 UTC) #17
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2130303002/ by machenbach@chromium.org.

The reason for reverting is: There are a bunch of goma errors on the gcc bot
now. Maybe connected to this CL.

https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/b....

Powered by Google App Engine
This is Rietveld 408576698