Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by Michael Achenbach Modified:
4 years, 5 months ago Reviewers:
jochen (gone - plz use gerrit), vogelheim CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@ng58 Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[gn] Switch gcc bots to gn
BUG=chromium:474921
Committed: https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393
Cr-Commit-Position: refs/heads/master@{#37580}
Patch Set 1 #Patch Set 2 : Fixes #Patch Set 3 : Rebase #
Created: 4 years, 5 months ago
Depends on Patchset: Messages
Total messages: 17 (8 generated)
Description was changed from ========== [gn] Switch gcc bots to gn BUG= ========== to ========== [gn] Switch gcc bots to gn BUG=chromium:474921 ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, vogelheim@chromium.org
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL. Flags after the sysroot and is_clang fix: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds...
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch gcc bots to gn BUG=chromium:474921 ========== to ========== [gn] Switch gcc bots to gn BUG=chromium:474921 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch gcc bots to gn BUG=chromium:474921 ========== to ========== [gn] Switch gcc bots to gn BUG=chromium:474921 Committed: https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393 Cr-Commit-Position: refs/heads/master@{#37580} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393 Cr-Commit-Position: refs/heads/master@{#37580}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2130303002/ by machenbach@chromium.org. The reason for reverting is: There are a bunch of goma errors on the gcc bot now. Maybe connected to this CL. https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/b.... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
