FrameLoader: Fix NavigationType for FrameLoadTypeReloadMainResource

FrameLoader: Fix NavigationType for FrameLoadTypeReloadMainResource

When I introduced FrameLoadTypeReloadMainResource, this modification
was not applied mistakenly. The right NavigationType for the one
is NavigationTypeReload as is for other reload variants' FrameLoadType.

This results in propagating a wrong is_reload flag to some delegates,
e.g. blink::WebLocalFrameImpl::dispatchBeforeUnloadEvent().

BUG=612701
Committed: https://crrev.com/4496d1472533b3c70eddbfd6519e6646bb710ef0
Cr-Commit-Position: refs/heads/master@{#404126}

[Takashi Toyoshima, 2016-07-07 08:45:40]

Description was changed from

==========
FrameLoader: Fix NavigationType for FrameLoadTypeReloadMainResource

When I introduced FrameLoadTypeReloadMainResource, this modification
was not applied mistakenly. The right NavigationType for the one
is NavigationTypeReload as for other reload variants' FrameLoadType.

This result in propagating a wrong is_reload flag to some delegates,
e.g. blink::WebLocalFrameImpl::dispatchBeforeUnloadEvent().

BUG=612701
==========

to

==========
FrameLoader: Fix NavigationType for FrameLoadTypeReloadMainResource

When I introduced FrameLoadTypeReloadMainResource, this modification
was not applied mistakenly. The right NavigationType for the one
is NavigationTypeReload as is for other reload variants' FrameLoadType.

This results in propagating a wrong is_reload flag to some delegates,
e.g. blink::WebLocalFrameImpl::dispatchBeforeUnloadEvent().

BUG=612701
==========

[Takashi Toyoshima, 2016-07-07 08:46:04]

toyoshim@chromium.org changed reviewers:
+ kinuko@chromium.org

[Takashi Toyoshima, 2016-07-07 08:56:17]

ptal

[kinuko, 2016-07-07 09:20:40]

looks good, any tests to capture this..?

[Takashi Toyoshima, 2016-07-07 09:50:30]

This bug should be captured by BrowserTest.BeforeUnloadVsBeforeReload if the
feature is enabled. That's how I notice this problem.

I will enable variations test (https://codereview.chromium.org/2128783002/) once
this change is submitted. It runs tests with my flag enabled too, and will
capture this until the feature is enabled by default.

[kinuko, 2016-07-07 10:41:37]

lgtm.

[Takashi Toyoshima, 2016-07-07 10:42:03]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-07-07 10:42:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 11:16:06]

Description was changed from

==========
FrameLoader: Fix NavigationType for FrameLoadTypeReloadMainResource

When I introduced FrameLoadTypeReloadMainResource, this modification
was not applied mistakenly. The right NavigationType for the one
is NavigationTypeReload as is for other reload variants' FrameLoadType.

This results in propagating a wrong is_reload flag to some delegates,
e.g. blink::WebLocalFrameImpl::dispatchBeforeUnloadEvent().

BUG=612701
==========

to

==========
FrameLoader: Fix NavigationType for FrameLoadTypeReloadMainResource

When I introduced FrameLoadTypeReloadMainResource, this modification
was not applied mistakenly. The right NavigationType for the one
is NavigationTypeReload as is for other reload variants' FrameLoadType.

This results in propagating a wrong is_reload flag to some delegates,
e.g. blink::WebLocalFrameImpl::dispatchBeforeUnloadEvent().

BUG=612701
==========

[commit-bot: I haz the power, 2016-07-07 11:16:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-07 11:16:14]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 11:17:50]

Description was changed from

==========
FrameLoader: Fix NavigationType for FrameLoadTypeReloadMainResource

When I introduced FrameLoadTypeReloadMainResource, this modification
was not applied mistakenly. The right NavigationType for the one
is NavigationTypeReload as is for other reload variants' FrameLoadType.

This results in propagating a wrong is_reload flag to some delegates,
e.g. blink::WebLocalFrameImpl::dispatchBeforeUnloadEvent().

BUG=612701
==========

to

==========
FrameLoader: Fix NavigationType for FrameLoadTypeReloadMainResource

When I introduced FrameLoadTypeReloadMainResource, this modification
was not applied mistakenly. The right NavigationType for the one
is NavigationTypeReload as is for other reload variants' FrameLoadType.

This results in propagating a wrong is_reload flag to some delegates,
e.g. blink::WebLocalFrameImpl::dispatchBeforeUnloadEvent().

BUG=612701

Committed: https://crrev.com/4496d1472533b3c70eddbfd6519e6646bb710ef0
Cr-Commit-Position: refs/heads/master@{#404126}
==========

[commit-bot: I haz the power, 2016-07-07 11:17:52]

Patchset 1 (id:??) landed as
https://crrev.com/4496d1472533b3c70eddbfd6519e6646bb710ef0
Cr-Commit-Position: refs/heads/master@{#404126}