chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java - Issue 2124243002: Refactor the Java AppBannerManager to be owned by native code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2124243002: Refactor the Java AppBannerManager to be owned by native code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java » ('j') | chrome/browser/banners/app_banner_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

index 28547bfbc1c1751139565e3e3d2f1112552c8a49..b369549608351605ca3200f4d26a2d3d29b87473 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

@@ -10,7 +10,6 @@ import org.chromium.base.ContextUtils;

import org.chromium.base.library_loader.LibraryProcessType;

import org.chromium.chrome.browser.ChromeApplication;

import org.chromium.chrome.browser.ShortcutHelper;

-import org.chromium.chrome.browser.banners.AppBannerManager;

import org.chromium.chrome.browser.externalnav.ExternalNavigationParams;

import org.chromium.chrome.browser.tab.InterceptNavigationDelegateImpl;

import org.chromium.chrome.browser.tab.Tab;

@@ -103,11 +102,11 @@ public class WebApkActivity extends WebappActivity {

}

@Override

- public AppBannerManager createAppBannerManager(Tab tab) {

+ public boolean canShowAppBanners(Tab tab) {

// Do not show app banners for WebAPKs regardless of the current page URL.

// A WebAPK can display a page outside of its WebAPK scope if a page within the

// WebAPK scope navigates via JavaScript while the WebAPK is in the background.

- return null;

+ return false;

}

};

}