Refactor the Java AppBannerManager to be owned by native code.

chrome/browser/banners/app_banner_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
 #define CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 22 matching lines @@
   static void DisableSecureSchemeCheckForTesting();
 
   static void SetEngagementWeights(double direct_engagement,
                                    double indirect_engagement);
 
   // Returns whether or not the URLs match for everything except for the ref.
   static bool URLsAreForTheSamePage(const GURL& first, const GURL& second);
 
   // Requests an app banner. Set |is_debug_mode| when it is triggered by the
   // developer's action in DevTools.
-  void RequestAppBanner(const GURL& validated_url, bool is_debug_mode);
+  virtual void RequestAppBanner(const GURL& validated_url, bool is_debug_mode);
 
   ~AppBannerManager() override;
 
  protected:
   explicit AppBannerManager(content::WebContents* web_contents);
 
   void ReplaceWebContents(content::WebContents* web_contents);

[pkotwicz, 2016/07/13 02:31:50]

Drive By! This function seems unused now

 
   // Creates an AppBannerDataFetcher, which constructs an app banner.
   virtual AppBannerDataFetcher* CreateAppBannerDataFetcher(
       base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate,
       bool is_debug_mode) = 0;
 
   // Return whether the AppBannerDataFetcher is active.
   bool IsFetcherActive();
 
   scoped_refptr<AppBannerDataFetcher> data_fetcher() { return data_fetcher_; }
@@ skipping 43 matching lines @@
   // longer than the lifetime of this banner manager. The banner manager
   // might be gone when calls sent to the ServiceWorkerContext are completed.
   base::WeakPtrFactory<AppBannerManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AppBannerManager);
 };  // class AppBannerManager
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_