Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2124223002: Convert video-[loop, double]* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-[loop, double]* tests to testharness.js Cleaning up video-[loop, double]* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/f3629c3cfc984d4c6e4a4b62f83da509c2fd6615 Cr-Commit-Position: refs/heads/master@{#404119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -419 lines) Patch
M third_party/WebKit/LayoutTests/media/video-double-seek-currentTime.html View 1 chunk +31 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-double-seek-currentTime-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-loop.html View 1 chunk +68 lines, -119 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-loop-expected.txt View 1 chunk +0 lines, -63 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-loop-from-ended.html View 1 chunk +54 lines, -88 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-loop-from-ended-expected.txt View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-07 07:13:26 UTC) #3
fs
lgtm
4 years, 5 months ago (2016-07-07 09:03:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124223002/1
4 years, 5 months ago (2016-07-07 09:21:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 10:34:27 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 10:34:32 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 10:35:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3629c3cfc984d4c6e4a4b62f83da509c2fd6615
Cr-Commit-Position: refs/heads/master@{#404119}

Powered by Google App Engine
This is Rietveld 408576698