DevTools: copy protocol files to front-end to fix hosted mode

DevTools: copy protocol files to front-end to fix hosted mode

DevTools "hosted mode" is broken in a multiple ways:
- it uses sync XHR from inside the microtask (this was recentrly forbidden)
- as the protocol was split and moved around, the InspectorBackendHostedMode.js
  is not able to generate proper inspector backend commands

The patch fixes both problems. Here we:
- manually copy browser_protocol.json and js_protocol.json to the front-end
  folder so that hosted mode can rely on it
- preload protocol files into Runtime.cachedResources in hosted mode for future
  use of InspectorBackendHostedMode.js

BUG=623602
R=dgozman, pfeldman

Committed: https://crrev.com/72620f081343cac603df3e17dfbd8b2607e2ab2d
Cr-Commit-Position: refs/heads/master@{#404447}

[lushnikov, 2016-07-07 02:01:09]

Description was changed from

==========
DevTools: copy protocol parts to front-end checkout to fix hosted mode

DevTools "hosted mode" is broken in a multiple ways:
- it uses sync XHR from inside the microtask (this was recentrly forbidden)
- as the protocol was split and moved around, the InspectorBackendHostedMode.js
  is not able to generate proper inspector backend commands

The patch fixes both problems. Here we:
- "enhance" Runtime.js to support async operations inside eval script
- manually copy browser_protocol.json and js_protocol.json to the front-end
  folder so that hosted mode can rely on it

BUG=623602
R=dgozman, pfeldman
==========

to

==========
DevTools: copy protocol files to front-end to fix hosted mode

DevTools "hosted mode" is broken in a multiple ways:
- it uses sync XHR from inside the microtask (this was recentrly forbidden)
- as the protocol was split and moved around, the InspectorBackendHostedMode.js
  is not able to generate proper inspector backend commands

The patch fixes both problems. Here we:
- "enhance" Runtime.js to support async operations inside eval script
- manually copy browser_protocol.json and js_protocol.json to the front-end
  folder so that hosted mode can rely on it

BUG=623602
R=dgozman, pfeldman
==========

[lushnikov, 2016-07-07 02:04:49]

please, take a look

[lushnikov, 2016-07-07 02:06:06]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 02:06:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 02:16:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 02:16:29]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-07-07 04:13:34]

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/Runtime.js:151: // Eval scripts as
fast as possible.
optional: We could sacrifice this optimization for the sake of simplicity - it
does not give us too much today anyways. We could load all and then eval all in
the self-invoking promise.

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/Runtime.js:181:
self.runtime.onAsyncEvalCompletion = null;
nuke

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/Runtime.js:182:
self.eval(scriptSource + "\n//# sourceURL=" + sourceURL);
var promise = self.eval(scriptSource + "\n//# sourceURL=" + sourceURL);
return promise instanceof Promise ? promise : null;

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/protocol/browser_protocol.json
(right):

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/protocol/browser_protocol.json:1: {
move further into sdk/protocol, add readme explaining how these files are used.

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js
(right):

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js:18:
self.runtime.onAsyncEvalCompletion = Promise.all(promises);
return Promise.all(promises);

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js:20:
function loadURL(url)
Annotate the url.

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js:23:
.then(response => response.text())
response =>
eval(WebInspector.InspectorBackendHostedMode.generateCommands(response.text()))

[dgozman, 2016-07-07 19:39:24]

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js
(right):

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js:18:
self.runtime.onAsyncEvalCompletion = Promise.all(promises);
Can we fetch the json even before calling Runtime.startApplication, and here
just eval it? We'll avoid any intrusion into Runtime.

[lushnikov, 2016-07-07 21:26:23]

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/Runtime.js:151: // Eval scripts as
fast as possible.
On 2016/07/07 04:13:34, pfeldman wrote:
> optional: We could sacrifice this optimization for the sake of simplicity - it
> does not give us too much today anyways. We could load all and then eval all
in
> the self-invoking promise.

Done.

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/Runtime.js:181:
self.runtime.onAsyncEvalCompletion = null;
On 2016/07/07 04:13:34, pfeldman wrote:
> nuke

Done.

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/Runtime.js:182:
self.eval(scriptSource + "\n//# sourceURL=" + sourceURL);
On 2016/07/07 04:13:34, pfeldman wrote:
> var promise = self.eval(scriptSource + "\n//# sourceURL=" + sourceURL);
> return promise instanceof Promise ? promise : null;

Done.

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/protocol/browser_protocol.json
(right):

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/protocol/browser_protocol.json:1: {
On 2016/07/07 04:13:34, pfeldman wrote:
> move further into sdk/protocol, add readme explaining how these files are
used.

Done.

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js
(right):

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js:18:
self.runtime.onAsyncEvalCompletion = Promise.all(promises);
On 2016/07/07 04:13:34, pfeldman wrote:
> return Promise.all(promises);

Done.

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js:20:
function loadURL(url)
On 2016/07/07 04:13:34, pfeldman wrote:
> Annotate the url.

Done.

https://codereview.chromium.org/2124203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js:23:
.then(response => response.text())
On 2016/07/07 04:13:34, pfeldman wrote:
> response =>
>
eval(WebInspector.InspectorBackendHostedMode.generateCommands(response.text()))

response.text() is a promise

I'd like to leave this as step-by-step as it doesn't impact performance but
makes reading easier

[pfeldman, 2016-07-07 23:25:44]

lgtm % comment

https://codereview.chromium.org/2124203002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js
(right):

https://codereview.chromium.org/2124203002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js:28:
.then(response => response.text())
I consider this an anti-pattern. Sync code should be executed synchronously,
there is no point in introducing overhead of instantiated promises and
microtasks.

[lushnikov, 2016-07-08 02:32:10]

A new approach, implementing the @dgozman suggestion. The
Runtime.cachedResources came handy! And overall, this looks good!

[lushnikov, 2016-07-08 02:33:40]

Description was changed from

==========
DevTools: copy protocol files to front-end to fix hosted mode

DevTools "hosted mode" is broken in a multiple ways:
- it uses sync XHR from inside the microtask (this was recentrly forbidden)
- as the protocol was split and moved around, the InspectorBackendHostedMode.js
  is not able to generate proper inspector backend commands

The patch fixes both problems. Here we:
- "enhance" Runtime.js to support async operations inside eval script
- manually copy browser_protocol.json and js_protocol.json to the front-end
  folder so that hosted mode can rely on it

BUG=623602
R=dgozman, pfeldman
==========

to

==========
DevTools: copy protocol files to front-end to fix hosted mode

DevTools "hosted mode" is broken in a multiple ways:
- it uses sync XHR from inside the microtask (this was recentrly forbidden)
- as the protocol was split and moved around, the InspectorBackendHostedMode.js
  is not able to generate proper inspector backend commands

The patch fixes both problems. Here we:
- manually copy browser_protocol.json and js_protocol.json to the front-end
  folder so that hosted mode can rely on it
- preload protocol files into Runtime.cachedResources in hosted mode for future
  use of InspectorBackendHostedMode.js

BUG=623602
R=dgozman, pfeldman
==========

[dgozman, 2016-07-08 05:45:07]

lgtm

https://codereview.chromium.org/2124203002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/2124203002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/Runtime.js:218: * @param {boolean=}
doNotAddSourceURL
Let's make it non-optional |addSourceURL|.

https://codereview.chromium.org/2124203002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js
(right):

https://codereview.chromium.org/2124203002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js:14:
var protocolURLs = Object.keys(Runtime.cachedResources).filter(url =>
url.indexOf("protocol.json") !== -1);
This code will be much easier without fancy functional programming:

for (var url of Object.keys(Runtime.cachedResources)) {
    if (url.indexOf("protocol.json") !== -1)
       
eval(WebInspector.InspectorBackendHostedMode.generateCommands(JSON.parse(Runtime.cachedResources[url])));
}

[lushnikov, 2016-07-08 17:09:53]

https://codereview.chromium.org/2124203002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/Runtime.js (right):

https://codereview.chromium.org/2124203002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/Runtime.js:218: * @param {boolean=}
doNotAddSourceURL
On 2016/07/08 05:45:07, dgozman wrote:
> Let's make it non-optional |addSourceURL|.

Done.

https://codereview.chromium.org/2124203002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js
(right):

https://codereview.chromium.org/2124203002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js:14:
var protocolURLs = Object.keys(Runtime.cachedResources).filter(url =>
url.indexOf("protocol.json") !== -1);
On 2016/07/08 05:45:07, dgozman wrote:
> This code will be much easier without fancy functional programming:
> 
> for (var url of Object.keys(Runtime.cachedResources)) {
>     if (url.indexOf("protocol.json") !== -1)
>        
>
eval(WebInspector.InspectorBackendHostedMode.generateCommands(JSON.parse(Runtime.cachedResources[url])));
> }

Done.

[lushnikov, 2016-07-08 17:10:02]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-07-08 17:10:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org, dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2124203002/#ps80001
(title: "address comments")

[commit-bot: I haz the power, 2016-07-08 17:10:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 18:28:27]

Description was changed from

==========
DevTools: copy protocol files to front-end to fix hosted mode

DevTools "hosted mode" is broken in a multiple ways:
- it uses sync XHR from inside the microtask (this was recentrly forbidden)
- as the protocol was split and moved around, the InspectorBackendHostedMode.js
  is not able to generate proper inspector backend commands

The patch fixes both problems. Here we:
- manually copy browser_protocol.json and js_protocol.json to the front-end
  folder so that hosted mode can rely on it
- preload protocol files into Runtime.cachedResources in hosted mode for future
  use of InspectorBackendHostedMode.js

BUG=623602
R=dgozman, pfeldman
==========

to

==========
DevTools: copy protocol files to front-end to fix hosted mode

DevTools "hosted mode" is broken in a multiple ways:
- it uses sync XHR from inside the microtask (this was recentrly forbidden)
- as the protocol was split and moved around, the InspectorBackendHostedMode.js
  is not able to generate proper inspector backend commands

The patch fixes both problems. Here we:
- manually copy browser_protocol.json and js_protocol.json to the front-end
  folder so that hosted mode can rely on it
- preload protocol files into Runtime.cachedResources in hosted mode for future
  use of InspectorBackendHostedMode.js

BUG=623602
R=dgozman, pfeldman
==========

[commit-bot: I haz the power, 2016-07-08 18:28:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-08 18:29:52]

Description was changed from

==========
DevTools: copy protocol files to front-end to fix hosted mode

DevTools "hosted mode" is broken in a multiple ways:
- it uses sync XHR from inside the microtask (this was recentrly forbidden)
- as the protocol was split and moved around, the InspectorBackendHostedMode.js
  is not able to generate proper inspector backend commands

The patch fixes both problems. Here we:
- manually copy browser_protocol.json and js_protocol.json to the front-end
  folder so that hosted mode can rely on it
- preload protocol files into Runtime.cachedResources in hosted mode for future
  use of InspectorBackendHostedMode.js

BUG=623602
R=dgozman, pfeldman
==========

to

==========
DevTools: copy protocol files to front-end to fix hosted mode

DevTools "hosted mode" is broken in a multiple ways:
- it uses sync XHR from inside the microtask (this was recentrly forbidden)
- as the protocol was split and moved around, the InspectorBackendHostedMode.js
  is not able to generate proper inspector backend commands

The patch fixes both problems. Here we:
- manually copy browser_protocol.json and js_protocol.json to the front-end
  folder so that hosted mode can rely on it
- preload protocol files into Runtime.cachedResources in hosted mode for future
  use of InspectorBackendHostedMode.js

BUG=623602
R=dgozman, pfeldman

Committed: https://crrev.com/72620f081343cac603df3e17dfbd8b2607e2ab2d
Cr-Commit-Position: refs/heads/master@{#404447}
==========

[commit-bot: I haz the power, 2016-07-08 18:29:54]

Patchset 5 (id:??) landed as
https://crrev.com/72620f081343cac603df3e17dfbd8b2607e2ab2d
Cr-Commit-Position: refs/heads/master@{#404447}