dart/sdk/lib/_internal/compiler/implementation/typechecker.dart - Issue 21242002: Retain elements a finer granularity than library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/typechecker.dart

Issue 21242002: Retain elements a finer granularity than library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/sdk/lib/_internal/compiler/implementation/typechecker.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/typechecker.dart b/dart/sdk/lib/_internal/compiler/implementation/typechecker.dart

index 41fc2b5959c14347f56825b95870db48a99abcca..4b314595bbc3f314be471dafeef880b1f465eb51 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/typechecker.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/typechecker.dart

@@ -189,7 +189,8 @@ class TypeCheckerVisitor extends Visitor<DartType> {

LibraryElement get currentLibrary => elements.currentElement.getLibrary();

reportTypeWarning(Node node, MessageKind kind, [Map arguments = const {}]) {

- compiler.reportWarning(node, new TypeWarning(kind, arguments));

+ compiler.reportWarning(

+ node, new TypeWarning(kind, arguments, compiler.terseDiagnostics));

}

reportTypeInfo(Spannable node, MessageKind kind, [Map arguments = const {}]) {