dart/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart - Issue 21242002: Retain elements a finer granularity than library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

Issue 21242002: Retain elements a finer granularity than library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart b/dart/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

index baaef0ba5bf4932824591a6cd7756eb6ef9cf25b..89e783b293d5aabc13a1593cf1b6d50cea63db3c 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

@@ -744,7 +744,9 @@ class TryCompileTimeConstantEvaluator extends CompileTimeConstantEvaluator {

error(Node node) {

// Just fail without reporting it anywhere.

- throw new CompileTimeConstantError(MessageKind.NOT_A_COMPILE_TIME_CONSTANT);

+ throw new CompileTimeConstantError(

+ MessageKind.NOT_A_COMPILE_TIME_CONSTANT, const {},

+ compiler.terseDiagnostics);

}