Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2124173002: mash: Migrate popup_message to ash/common. (Closed)

Created:
4 years, 5 months ago by msw
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Migrate popup_message to ash/common. tools/git/move_source_file.py ash/popup_message* ash/common/ Allow ash/test DEPS for any ash/common/.*test\.cc files. These files are used by ash/system/user. BUG=619636 TEST=compiles; no behavior changes. R=jamescook@chromium.org Committed: https://crrev.com/79ad061f6ba5c36106c916326caf0bc7013a7198 Cr-Commit-Position: refs/heads/master@{#404219}

Patch Set 1 #

Patch Set 2 : Cleanup. #

Total comments: 1

Patch Set 3 : Sync and rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -389 lines) Patch
M ash/ash.gyp View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M ash/common/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A + ash/common/popup_message.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/popup_message.cc View 1 4 chunks +12 lines, -10 lines 0 comments Download
A + ash/common/popup_message_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/DEPS View 1 chunk +1 line, -7 lines 0 comments Download
D ash/popup_message.h View 1 chunk +0 lines, -82 lines 0 comments Download
D ash/popup_message.cc View 1 chunk +0 lines, -231 lines 0 comments Download
D ash/popup_message_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M ash/system/user/user_view.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
msw
Hey James, please take a look; thanks! https://codereview.chromium.org/2124173002/diff/20001/ash/common/popup_message.cc File ash/common/popup_message.cc (right): https://codereview.chromium.org/2124173002/diff/20001/ash/common/popup_message.cc#newcode225 ash/common/popup_message.cc:225: if (!widget_) ...
4 years, 5 months ago (2016-07-06 23:43:12 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124173002/20001
4 years, 5 months ago (2016-07-06 23:53:04 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 00:32:46 UTC) #7
James Cook
LGTM
4 years, 5 months ago (2016-07-07 02:13:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124173002/20001
4 years, 5 months ago (2016-07-07 16:55:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124173002/40001
4 years, 5 months ago (2016-07-07 18:20:55 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-07 19:50:54 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 19:52:28 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/79ad061f6ba5c36106c916326caf0bc7013a7198
Cr-Commit-Position: refs/heads/master@{#404219}

Powered by Google App Engine
This is Rietveld 408576698