Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2124143005: Revert of Teach HistoryItem about a request's initiator. (Closed)

Created:
4 years, 5 months ago by Charlie Reis
Modified:
4 years, 5 months ago
Reviewers:
Yoav Weiss, Mike West
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Teach HistoryItem about a request's initiator. (patchset #2 id:20001 of https://codereview.chromium.org/2130623003/ ) Reason for revert: Failing on Site Isolation Linux FYI bot: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/9841 Also appears to have problems with restored session history items. Original issue's description: > Teach HistoryItem about a request's initiator. > > Currently, we don't store enough information on HistoryItem to deal > correctly with 'SameSite' cookies for cases in which the user navigates > their history. This patch adds the initiator of the original request to > the HistoryItem, and restores it as part of the navigation work in > FrameLoader. > > BUG=626243 > R=yoav@yoav.ws > > Committed: https://crrev.com/c19960b67391c5789878f475163b813ad9daf994 > Cr-Commit-Position: refs/heads/master@{#404123} TBR=yoav@yoav.ws,mkwst@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626243 Committed: https://crrev.com/991714e6f6dbfae1e3b5896ce184ce25172788d0 Cr-Commit-Position: refs/heads/master@{#404258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -40 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/cookies/resources/post-cookies-to-opener.php View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HistoryItem.h View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HistoryItem.cpp View 3 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Charlie Reis
Created Revert of Teach HistoryItem about a request's initiator.
4 years, 5 months ago (2016-07-07 22:08:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124143005/1
4 years, 5 months ago (2016-07-07 22:08:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 22:22:04 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 22:22:30 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 22:23:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/991714e6f6dbfae1e3b5896ce184ce25172788d0
Cr-Commit-Position: refs/heads/master@{#404258}

Powered by Google App Engine
This is Rietveld 408576698