Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2124143002: Fix blimp native Java tests on platforms with assert. (Closed)

Created:
4 years, 5 months ago by nyquist
Modified:
4 years, 5 months ago
Reviewers:
Khushal
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix blimp native Java tests on platforms with assert. The BlimpNativeInstrumentationTestCase wrapper for blimp tests that need to load native code to run was not using the UI thread for loading the library. There was an assert checking for this, but this doesn't execute on newer platforms, so was not caught during development or in the CQ. This CL fixes the issue by ensuring that the library is loaded on the correct thread. BUG=622236 Committed: https://crrev.com/58701445475f240357b16f4fd2bb46a489247f7d Cr-Commit-Position: refs/heads/master@{#403965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M blimp/client/app/android/javatests/src/org/chromium/blimp/BlimpNativeInstrumentationTestCase.java View 2 chunks +17 lines, -7 lines 0 comments Download
M blimp/client/app/android/javatests/src/org/chromium/blimp/core/BlimpContentsTest.java View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nyquist
khushalsagar: PTAL
4 years, 5 months ago (2016-07-06 21:54:07 UTC) #2
Khushal
On 2016/07/06 21:54:07, nyquist wrote: > khushalsagar: PTAL lgtm.
4 years, 5 months ago (2016-07-06 22:03:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124143002/1
4 years, 5 months ago (2016-07-06 22:04:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 23:07:15 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 23:07:30 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 23:08:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58701445475f240357b16f4fd2bb46a489247f7d
Cr-Commit-Position: refs/heads/master@{#403965}

Powered by Google App Engine
This is Rietveld 408576698