tracing/tracing/ui/base/line_chart.html - Issue 2124113002: Fix chart legends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/base/line_chart.html

Issue 2124113002: Fix chart legends. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: finished refactoring DataSeries Map Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/ui/base/line_chart.html

diff --git a/tracing/tracing/ui/base/line_chart.html b/tracing/tracing/ui/base/line_chart.html

index ba43169524233dfc9874eae9ec9cfb99eda9a80f..5b479fc66655831e6e5a499dd593762e34c7064d 100644

--- a/tracing/tracing/ui/base/line_chart.html

+++ b/tracing/tracing/ui/base/line_chart.html

@@ -39,7 +39,8 @@ tr.exportTo('tr.ui.b', function() {

updateDataContents_: function(dataSel) {

dataSel.selectAll('*').remove();

var dataBySeriesKey = this.getDataBySeriesKey_();

- var pathsSel = dataSel.selectAll('path').data(this.seriesKeys_);

+ var seriesKeys = [...this.seriesByKey_.keys()];

+ var pathsSel = dataSel.selectAll('path').data(seriesKeys);

pathsSel.enter()

.append('path')

.attr('class', 'line')

« no previous file with comments | « tracing/tracing/ui/base/chart_base_2d.html ('k') | tracing/tracing/ui/base/pie_chart.html » ('j') | no next file with comments »