Remove VideoCaptureDeviceClient buffer warning logs

content/browser/renderer_host/media/video_capture_device_client.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/video_capture_device_client.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 120 matching lines @@
     rotation_mode = libyuv::kRotate270;
 
   const gfx::Size dimensions(destination_width, destination_height);
   const media::VideoPixelStorage output_pixel_storage =
       use_gpu_memory_buffers_ ? media::PIXEL_STORAGE_GPUMEMORYBUFFER
                               : media::PIXEL_STORAGE_CPU;
   uint8_t *y_plane_data, *u_plane_data, *v_plane_data;
   std::unique_ptr<Buffer> buffer(
       ReserveI420OutputBuffer(dimensions, output_pixel_storage, &y_plane_data,
                               &u_plane_data, &v_plane_data));
-  if (!buffer.get()) {
-    DLOG(WARNING) << "Failed to reserve I420 output buffer.";
+#if DCHECK_IS_ON()
+  dropped_frame_counter_ = buffer.get() ? 0 : dropped_frame_counter_ + 1;
+  DCHECK_LT(dropped_frame_counter_, 150u)

[mcasas, 2016/07/13 00:31:36]

I'd recommend defining a constant 
 static const int kMaxDroppedFrames = 150u
next to the declaration of |dropped_frame_counter_|.

Also, I'd make |drop_frame_counter_| int, since
I don't see any particular reason to use sophisticated
(and discouraged, because unsigned) data types.

Finally, why have a separate debug version of error
handling and not just do here a
OnError(FROM_HERE, "Too many frames dropped");
?

[emircan, 2016/07/13 17:51:14]

Changed |dropped_frame_counter_| to int and declared |kMaxDroppedFrames|. This
macro gives me the syntactic sugar for int comparison. I will go for CHECK_LT()
so that it doesn't go through debug version.

[emircan, 2016/07/13 18:24:55]

Nvm. I just realized OnError is a call within this function. Switching to that.

+      << " Dropped too many consecutive captured frames.";
+#endif
+    // Failed to reserve I420 output buffer, so drop the frame.

[mcasas, 2016/07/13 00:31:36]

nit: Shift l.146 two spaces left.

[emircan, 2016/07/13 17:51:14]

Done.

+  if (!buffer.get())
     return;
-  }
 
   const int yplane_stride = dimensions.width();
   const int uv_plane_stride = yplane_stride / 2;
   int crop_x = 0;
   int crop_y = 0;
   libyuv::FourCC origin_colorspace = libyuv::FOURCC_ANY;
 
   bool flip = false;
   switch (frame_format.pixel_format) {
     case media::PIXEL_FORMAT_UNKNOWN:  // Color format not set.
@@ skipping 262 matching lines @@
           reinterpret_cast<uint8_t*>(buffer->data(VideoFrame::kUPlane));
       *v_plane_data =
           reinterpret_cast<uint8_t*>(buffer->data(VideoFrame::kVPlane));
       return buffer;
   }
   NOTREACHED();
   return std::unique_ptr<Buffer>();
 }
 
 }  // namespace content