Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 2124063002: Remove forward declarations of non-existent class. (Closed)

Created:
4 years, 5 months ago by hush (inactive)
Modified:
4 years, 5 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove forward declarations of non-existent class. BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/5a6cb1bf59eacb7bf328add80054eeb670a535fe Cr-Commit-Position: refs/heads/master@{#404475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M cc/input/input_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/android/synchronous_compositor_client.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124063002/1
4 years, 5 months ago (2016-07-06 18:56:15 UTC) #3
hush (inactive)
Hello, PTAL. aelias@ for cc/ and torne for content/. (This class was removed about a ...
4 years, 5 months ago (2016-07-06 18:56:44 UTC) #5
aelias_OOO_until_Jul13
lgtm
4 years, 5 months ago (2016-07-06 22:25:14 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99210)
4 years, 5 months ago (2016-07-06 23:11:32 UTC) #8
Torne
LGTM - though I didn't realise I was an OWNER here and probably shouldn't be? ...
4 years, 5 months ago (2016-07-08 10:07:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124063002/1
4 years, 5 months ago (2016-07-08 18:16:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/214444)
4 years, 5 months ago (2016-07-08 18:26:33 UTC) #13
hush (inactive)
On 2016/07/08 18:26:33, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 5 months ago (2016-07-08 18:32:10 UTC) #14
hush (inactive)
Hello Yaron, PTAL content/
4 years, 5 months ago (2016-07-08 18:33:58 UTC) #16
Yaron
lgtm
4 years, 5 months ago (2016-07-08 19:08:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124063002/1
4 years, 5 months ago (2016-07-08 20:08:56 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 20:13:25 UTC) #20
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5a6cb1bf59eacb7bf328add80054eeb670a535fe Cr-Commit-Position: refs/heads/master@{#404475}
4 years, 5 months ago (2016-07-08 20:16:09 UTC) #22
Torne
4 years, 5 months ago (2016-07-11 14:02:46 UTC) #23
Message was sent while issue was closed.
On 2016/07/08 18:32:10, hush wrote:
> On 2016/07/08 18:26:33, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> what... how could it be...
> did you just remove yourself from OWNERS torne?

Oops, sorry, yes. After LGTMing this, I went and removed myself from OWNERS so I
wouldn't be sent any more code reviews about this file, and totally forgot that
this meant my LGTM here would no longer be valid. :)

Powered by Google App Engine
This is Rietveld 408576698