Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2124013002: [Layout API] Use layoutViewItem() in StyleResolver (Closed)

Created:
4 years, 5 months ago by pilgrim_google
Modified:
4 years, 5 months ago
Reviewers:
eae, jsbell
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use layoutViewItem() in StyleResolver Document::layoutView() is deprecated and being removed soon. The replacement is Document::layoutViewItem(), which routes methods through the new block layout API. No new API methods were required. There are no functional changes. BUG=499321 Committed: https://crrev.com/b04064cfeecd20d89bee248dfe95b693af8c5359 Cr-Commit-Position: refs/heads/master@{#405573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pilgrim_google
4 years, 5 months ago (2016-07-06 17:04:51 UTC) #2
eae
LGTM
4 years, 5 months ago (2016-07-06 17:24:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124013002/1
4 years, 5 months ago (2016-07-14 19:55:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 21:22:22 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 21:22:25 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 21:23:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b04064cfeecd20d89bee248dfe95b693af8c5359
Cr-Commit-Position: refs/heads/master@{#405573}

Powered by Google App Engine
This is Rietveld 408576698