chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java - Issue 2124003004: Force to exit full screen video upon receiving ESCAPE key event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java

Issue 2124003004: Force to exit full screen video upon receiving ESCAPE key event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Kept protected scope of exitFullscreenIfShowing() API Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java b/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java

index 8c2602fd3ef866c96ea7f8b50ab0c342b37bfb47..0655c4cd29d14fcdc5d979d0206909c510031f21 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java

@@ -70,6 +70,10 @@ public class KeyboardShortcuts {

activity.onMenuOrKeyboardAction(R.id.show_menu, false);

}

return true;

+ case KeyEvent.KEYCODE_ESCAPE:

+ if (event.getAction() == KeyEvent.ACTION_DOWN && event.getRepeatCount() == 0) {

+ return activity.exitFullscreenIfShowing();

+ }

case KeyEvent.KEYCODE_TV:

case KeyEvent.KEYCODE_GUIDE:

case KeyEvent.KEYCODE_DVR:

« no previous file with comments | « no previous file | no next file » | no next file with comments »