Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2124003003: [gn] Fix sysroot usage with gcc (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Fix sysroot usage with gcc BUG=chromium:474921 TBR=jochen@chromium.org, vogelheim@chromium.org, NOTRY=true Committed: https://crrev.com/207fd4b9cd741728cfd2ebe77d1ffe232f921965 Cr-Commit-Position: refs/heads/master@{#37575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M infra/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Achenbach
PTAL. Looks like gcc and sysroot don't work together in gn either. We didn't support ...
4 years, 5 months ago (2016-07-07 09:21:06 UTC) #3
Michael Achenbach
Works with the trybot now: https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/18983/steps/generate_build_files%20with%20gn%20%28fyi%29/logs/stdio
4 years, 5 months ago (2016-07-07 09:23:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124003003/1
4 years, 5 months ago (2016-07-07 09:24:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 09:26:15 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/207fd4b9cd741728cfd2ebe77d1ffe232f921965 Cr-Commit-Position: refs/heads/master@{#37575}
4 years, 5 months ago (2016-07-07 09:27:57 UTC) #10
vogelheim
4 years, 5 months ago (2016-07-07 10:58:32 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698