Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Issue 2124003002: [Layout API] Use layoutViewItem() in VisualViewportTest (Closed)

Created:
4 years, 5 months ago by pilgrim_google
Modified:
4 years, 5 months ago
Reviewers:
eae, jsbell
CC:
blink-reviews, chromium-reviews, kinuko+watch, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use layoutViewItem() in VisualViewportTest Frameview::layoutView() is deprecated and being removed soon. The replacement is Frameview::layoutViewItem(), which routes methods through the new block layout API. No new API methods were required. There are no functional changes. BUG=499321 Committed: https://crrev.com/d532669d38c1ebf0137a31abc2683fb6e1a27d60 Cr-Commit-Position: refs/heads/master@{#403982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
pilgrim_google
4 years, 5 months ago (2016-07-06 16:57:14 UTC) #2
eae
LGTM
4 years, 5 months ago (2016-07-06 23:32:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124003002/1
4 years, 5 months ago (2016-07-06 23:33:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 23:40:48 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 23:41:04 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 23:44:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d532669d38c1ebf0137a31abc2683fb6e1a27d60
Cr-Commit-Position: refs/heads/master@{#403982}

Powered by Google App Engine
This is Rietveld 408576698