Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 2123993002: Fixed CronetHttpURLConnectionTest failure on Android N (Closed)

Created:
4 years, 5 months ago by kapishnikov
Modified:
4 years, 5 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed CronetHttpURLConnectionTest failure on Android N + use Build.VERSION_CODES instead of integers. BUG=625188 Committed: https://crrev.com/a54e6130d0c0d66f615b61b92230cb6b75acb737 Cr-Commit-Position: refs/heads/master@{#403921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestFactory.java View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kapishnikov
This change fixes one of the four tests that fail on Android N.
4 years, 5 months ago (2016-07-06 15:46:28 UTC) #2
xunjieli
On 2016/07/06 15:46:28, kapishnikov wrote: > This change fixes one of the four tests that ...
4 years, 5 months ago (2016-07-06 15:48:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123993002/1
4 years, 5 months ago (2016-07-06 16:11:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 17:06:05 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 17:08:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a54e6130d0c0d66f615b61b92230cb6b75acb737
Cr-Commit-Position: refs/heads/master@{#403921}

Powered by Google App Engine
This is Rietveld 408576698