Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: src/x64/code-stubs-x64.cc

Issue 2123983004: [ic] Split megamorphic stub cache in two caches (for loads and for stores). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@flags-fix
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/api-arguments.h" 8 #include "src/api-arguments.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 3372 matching lines...) Expand 10 before | Expand all | Expand 10 after
3383 // Is it a fixed array? 3383 // Is it a fixed array?
3384 __ bind(&try_array); 3384 __ bind(&try_array);
3385 __ CompareRoot(FieldOperand(feedback, 0), Heap::kFixedArrayMapRootIndex); 3385 __ CompareRoot(FieldOperand(feedback, 0), Heap::kFixedArrayMapRootIndex);
3386 __ j(not_equal, &not_array); 3386 __ j(not_equal, &not_array);
3387 HandleArrayCases(masm, feedback, receiver_map, integer_slot, r11, r15, true, 3387 HandleArrayCases(masm, feedback, receiver_map, integer_slot, r11, r15, true,
3388 &miss); 3388 &miss);
3389 3389
3390 __ bind(&not_array); 3390 __ bind(&not_array);
3391 __ CompareRoot(feedback, Heap::kmegamorphic_symbolRootIndex); 3391 __ CompareRoot(feedback, Heap::kmegamorphic_symbolRootIndex);
3392 __ j(not_equal, &miss); 3392 __ j(not_equal, &miss);
3393 Code::Flags code_flags = 3393 masm->isolate()->load_stub_cache()->GenerateProbe(masm, receiver, name,
3394 Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::LOAD_IC)); 3394 feedback, no_reg);
3395 masm->isolate()->stub_cache()->GenerateProbe(
3396 masm, Code::LOAD_IC, code_flags, receiver, name, feedback, no_reg);
3397 3395
3398 __ bind(&miss); 3396 __ bind(&miss);
3399 LoadIC::GenerateMiss(masm); 3397 LoadIC::GenerateMiss(masm);
3400 3398
3401 __ bind(&load_smi_map); 3399 __ bind(&load_smi_map);
3402 __ LoadRoot(receiver_map, Heap::kHeapNumberMapRootIndex); 3400 __ LoadRoot(receiver_map, Heap::kHeapNumberMapRootIndex);
3403 __ jmp(&compare_map); 3401 __ jmp(&compare_map);
3404 } 3402 }
3405 3403
3406 3404
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
3525 __ bind(&try_array); 3523 __ bind(&try_array);
3526 __ CompareRoot(FieldOperand(feedback, 0), Heap::kFixedArrayMapRootIndex); 3524 __ CompareRoot(FieldOperand(feedback, 0), Heap::kFixedArrayMapRootIndex);
3527 __ j(not_equal, &not_array); 3525 __ j(not_equal, &not_array);
3528 HandleArrayCases(masm, feedback, receiver_map, integer_slot, r14, r15, true, 3526 HandleArrayCases(masm, feedback, receiver_map, integer_slot, r14, r15, true,
3529 &miss); 3527 &miss);
3530 3528
3531 __ bind(&not_array); 3529 __ bind(&not_array);
3532 __ CompareRoot(feedback, Heap::kmegamorphic_symbolRootIndex); 3530 __ CompareRoot(feedback, Heap::kmegamorphic_symbolRootIndex);
3533 __ j(not_equal, &miss); 3531 __ j(not_equal, &miss);
3534 3532
3535 Code::Flags code_flags = 3533 masm->isolate()->store_stub_cache()->GenerateProbe(masm, receiver, key,
3536 Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC)); 3534 feedback, no_reg);
3537 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, code_flags,
3538 receiver, key, feedback, no_reg);
3539 3535
3540 __ bind(&miss); 3536 __ bind(&miss);
3541 StoreIC::GenerateMiss(masm); 3537 StoreIC::GenerateMiss(masm);
3542 3538
3543 __ bind(&load_smi_map); 3539 __ bind(&load_smi_map);
3544 __ LoadRoot(receiver_map, Heap::kHeapNumberMapRootIndex); 3540 __ LoadRoot(receiver_map, Heap::kHeapNumberMapRootIndex);
3545 __ jmp(&compare_map); 3541 __ jmp(&compare_map);
3546 } 3542 }
3547 3543
3548 3544
(...skipping 1670 matching lines...) Expand 10 before | Expand all | Expand 10 after
5219 kStackUnwindSpace, nullptr, return_value_operand, 5215 kStackUnwindSpace, nullptr, return_value_operand,
5220 NULL); 5216 NULL);
5221 } 5217 }
5222 5218
5223 #undef __ 5219 #undef __
5224 5220
5225 } // namespace internal 5221 } // namespace internal
5226 } // namespace v8 5222 } // namespace v8
5227 5223
5228 #endif // V8_TARGET_ARCH_X64 5224 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/ic/x64/stub-cache-x64.cc ('K') | « src/type-info.cc ('k') | src/x87/code-stubs-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698