Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js

Issue 2123983003: PDF: Replace usage of i18nTemplate with Polymer data binding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js
diff --git a/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js b/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js
index 870b7e05424b821074997326755a4789f759adab..a7586c26d62ff9862381d0d678ab09d961d365e9 100644
--- a/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js
+++ b/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.js
@@ -11,6 +11,11 @@
is: 'viewer-zoom-toolbar',
properties: {
+ strings: {
+ type: Object,
+ observer: 'updateTooltips_'
+ },
+
visible_: {
type: Boolean,
value: true
@@ -24,15 +29,13 @@
/**
* Change button tooltips to match any changes to loadTimeData.
raymes 2016/07/12 05:21:49 is this comment still accurate?
tsergeant 2016/07/12 06:11:39 Not quite, I've tweaked it to reflect the changes.
*/
- updateTooltips: function() {
+ updateTooltips_: function() {
this.$['fit-button'].tooltips = [
- loadTimeData.getString('tooltipFitToPage'),
- loadTimeData.getString('tooltipFitToWidth')
+ this.strings.tooltipFitToPage,
+ this.strings.tooltipFitToWidth
];
- this.$['zoom-in-button'].tooltips =
- [loadTimeData.getString('tooltipZoomIn')];
- this.$['zoom-out-button'].tooltips =
- [loadTimeData.getString('tooltipZoomOut')];
+ this.$['zoom-in-button'].tooltips = [this.strings.tooltipZoomIn];
+ this.$['zoom-out-button'].tooltips = [this.strings.tooltipZoomOut];
},
fitToggle: function() {

Powered by Google App Engine
This is Rietveld 408576698