Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2123973003: Remove redundant uint64_t typedef (Closed)

Created:
4 years, 5 months ago by dmurph
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant uint64_t typedef This was created by this refactoring patch: https://codereview.chromium.org/1538743002 R=avi@chromium.org, mark@chromium.org BUG= Committed: https://crrev.com/571688d2b8f04c270521df62a6508fc38c1cbee7 Cr-Commit-Position: refs/heads/master@{#404201}

Patch Set 1 #

Patch Set 2 : added newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/third_party/symbolize/utilities.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
dmurph
4 years, 5 months ago (2016-07-07 00:34:56 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 5 months ago (2016-07-07 01:16:11 UTC) #2
Mark Mentovai
Hahaha! I’d put a blank line between the #includes and the #defines, but LGTM.
4 years, 5 months ago (2016-07-07 03:52:19 UTC) #3
dmurph
On 2016/07/07 03:52:19, Mark Mentovai wrote: > Hahaha! > > I’d put a blank line ...
4 years, 5 months ago (2016-07-07 17:24:33 UTC) #4
dmurph
4 years, 5 months ago (2016-07-07 17:24:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123973003/20001
4 years, 5 months ago (2016-07-07 17:26:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 19:06:33 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 19:09:47 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/571688d2b8f04c270521df62a6508fc38c1cbee7
Cr-Commit-Position: refs/heads/master@{#404201}

Powered by Google App Engine
This is Rietveld 408576698