Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2123963002: Roll gyp to bac4680ec9a5c55ab692490b6732999648ecf1e9. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@{0}
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll gyp to bac4680ec9a5c55ab692490b6732999648ecf1e9. This is to bring the following changes: bac4680 Only call CopyStringsFile if convert_to_binary is False. 35eafcd Ignore more Xcode stderr logging information. BUG=625578 Committed: https://crrev.com/3f5cafaf4b809d08cbf98fef048942c5fb4aaf60 Cr-Commit-Position: refs/heads/master@{#403922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
sdefresne
Please take a look.
4 years, 5 months ago (2016-07-06 15:16:57 UTC) #2
sdefresne
Please send to CQ if LGTY.
4 years, 5 months ago (2016-07-06 16:48:09 UTC) #3
justincohen
lgtm
4 years, 5 months ago (2016-07-06 16:51:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123963002/1
4 years, 5 months ago (2016-07-06 17:02:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 17:06:39 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 17:06:43 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 17:08:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f5cafaf4b809d08cbf98fef048942c5fb4aaf60
Cr-Commit-Position: refs/heads/master@{#403922}

Powered by Google App Engine
This is Rietveld 408576698