Web Animations API: Ensure timing is updated if a RAF callback makes a player outdated.

Web Animations API: Ensure timing is updated if a RAF callback makes a player outdated.

Under the Web Animations API it's now possible for new animation players to be
started or existing players modified during frame callbacks. Since timing
updates are lazy it was possible for them to be delayed until the next frame.

This patch forces an update of any outdated players following the execution
of frame callbacks.

NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170169

[esprehn, 2014-03-26 08:08:38]

On 2014/03/26 08:02:08, dstockwell wrote:

Why don't you need to consider the transitions timeline?

Lgtm

[dstockwell, 2014-03-26 08:14:13]

On 2014/03/26 08:08:38, esprehn wrote:
> On 2014/03/26 08:02:08, dstockwell wrote:
> 
> Why don't you need to consider the transitions timeline?
> 
> Lgtm

CSS transitions and animations aren't exposed through the API. API animations
are only added to the document timeline, never the transition timeline.

I can add an assert that there are no outdated players on the transition
timeline.

[shans, 2014-03-26 20:14:47]

lgtm

Once we have player end events, updating a player that ends should trigger the
event to fire on the *next* frame still, right?

[shans, 2014-03-26 20:15:11]

On 2014/03/26 20:14:47, shans wrote:
> lgtm
> 
> Once we have player end events, updating a player that ends should trigger the
> event to fire on the *next* frame still, right?

(updating a player that ends in this new code path)

[rjwright, 2014-03-27 02:42:18]

The CQ bit was checked by rjwright@chromium.org

[rjwright, 2014-03-27 02:42:20]

The CQ bit was unchecked by rjwright@chromium.org

[dstockwell, 2014-03-27 10:55:07]

On 2014/03/26 08:14:13, dstockwell wrote:
> On 2014/03/26 08:08:38, esprehn wrote:
> > On 2014/03/26 08:02:08, dstockwell wrote:
> > 
> > Why don't you need to consider the transitions timeline?
> > 
> > Lgtm
> 
> CSS transitions and animations aren't exposed through the API. API animations
> are only added to the document timeline, never the transition timeline.
> 
> I can add an assert that there are no outdated players on the transition
> timeline.

Had to remove the assert as it triggers in some calendar-picker tests that use
EventSender::keyDown and end up causing a full compositing update within a
RAF callback :/

On 2014/03/26 20:14:47, shans wrote:
> lgtm
> 
> Once we have player end events, updating a player that ends should trigger the
> event to fire on the *next* frame still, right?

Yes. Events and custom effect callbacks should only trigger on the initial
service
for a frame.

[dstockwell, 2014-03-27 10:55:17]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2014-03-27 10:55:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/212393002/130001

[commit-bot: I haz the power, 2014-03-27 11:06:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 11:06:05]

Try jobs failed on following builders:
  tryserver.blink on win_blink_compile_dbg

[dstockwell, 2014-03-27 11:07:56]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2014-03-27 11:08:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/212393002/130001

[commit-bot: I haz the power, 2014-03-27 12:01:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 12:01:19]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[dstockwell, 2014-03-27 12:05:58]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2014-03-27 12:06:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/212393002/130001

[commit-bot: I haz the power, 2014-03-27 12:06:43]

Change committed as 170169