Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2123923002: [Payments] Dedupe contact info, and phone and email editor suggestions. (Closed)

Created:
4 years, 5 months ago by sebsg
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Payments] Dedupe contact info, and phone and email editor suggestions. BUG=624869 Review-Url: https://codereview.chromium.org/2122493003 Cr-Commit-Position: refs/heads/master@{#403651} (cherry picked from commit 24fa769ff3ee4d66bc7867ae6f508636b372ef30) NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -30 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java View 4 chunks +4 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 3 chunks +15 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123923002/1
4 years, 5 months ago (2016-07-06 11:12:07 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-06 11:12:08 UTC) #4
please use gerrit instead
lgtm
4 years, 5 months ago (2016-07-06 11:13:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123923002/1
4 years, 5 months ago (2016-07-06 11:13:58 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 5 months ago (2016-07-06 11:14:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123923002/1
4 years, 5 months ago (2016-07-06 11:15:24 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 11:17:27 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 11:17:32 UTC) #16
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698