Introduce class RelocatablePosition

Introduce class RelocatablePosition

|RelocatablePosition| is a helper class for keeping track of a |Position| in
a document upon DOM tree changes even if the given |Position|'s original
anchor node is moved out of document. The class is implemented by using a
temporary |Range| object to keep track of the |Position|, and disposing the
|Range| when out of scope.

|RelocatablePosition| will be used in editing code, for example:

https://codereview.chromium.org/2127503002/

BUG=n/a
TEST=webkit_unit_tests --gtest_filter=RelocatablePositionTest.position

Committed: https://crrev.com/485ff73a6daeed372189a91ff19edb88ebea18b0
Cr-Commit-Position: refs/heads/master@{#403878}

[Xiaocheng, 2016-07-06 07:43:37]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[Xiaocheng, 2016-07-06 07:43:38]

PTAL.

[yosin_UTC9, 2016-07-06 07:48:19]

lgtm w/ small nits

https://codereview.chromium.org/2123893002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp (right):

https://codereview.chromium.org/2123893002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp:17: const
char* bodyContent = "<b>foo</b><textarea>bar</textarea>";
nit: You don't need to have |bodyContent|.

https://codereview.chromium.org/2123893002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp:20: Node* b =
document().querySelector("b", ASSERT_NO_EXCEPTION);
nit: please avoid to use one letter variable name.

https://codereview.chromium.org/2123893002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp:24:
document().body()->removeChild(textarea);
nit: |textarea->remove()| is easier.

[tkent, 2016-07-06 07:50:25]

lgtm

[Xiaocheng, 2016-07-06 08:00:05]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-07-06 08:00:06]

Thanks for your review!

https://codereview.chromium.org/2123893002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp (right):

https://codereview.chromium.org/2123893002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp:17: const
char* bodyContent = "<b>foo</b><textarea>bar</textarea>";
On 2016/07/06 at 07:48:19, Yosi_UTC9 wrote:
> nit: You don't need to have |bodyContent|.

Done.

https://codereview.chromium.org/2123893002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp:20: Node* b =
document().querySelector("b", ASSERT_NO_EXCEPTION);
On 2016/07/06 at 07:48:19, Yosi_UTC9 wrote:
> nit: please avoid to use one letter variable name.

Done.

https://codereview.chromium.org/2123893002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/RelocatablePositionTest.cpp:24:
document().body()->removeChild(textarea);
On 2016/07/06 at 07:48:19, Yosi_UTC9 wrote:
> nit: |textarea->remove()| is easier.

Done.

[Xiaocheng, 2016-07-06 08:00:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2123893002/#ps20001
(title: "nits fixed")

[commit-bot: I haz the power, 2016-07-06 08:00:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 08:27:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 08:27:20]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Xiaocheng, 2016-07-06 08:39:10]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-07-06 08:39:11]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2123893002/#ps40001
(title: "Add CORE_EXPORT")

[commit-bot: I haz the power, 2016-07-06 08:39:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 09:58:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-06 10:00:51]

Description was changed from

==========
Introduce class RelocatablePosition

|RelocatablePosition| is a helper class for keeping track of a |Position| in
a document upon DOM tree changes even if the given |Position|'s original
anchor node is moved out of document. The class is implemented by using a
temporary |Range| object to keep track of the |Position|, and disposing the
|Range| when out of scope.

|RelocatablePosition| will be used in editing code, for example:

https://codereview.chromium.org/2127503002/

BUG=n/a
TEST=webkit_unit_tests --gtest_filter=RelocatablePositionTest.position
==========

to

==========
Introduce class RelocatablePosition

|RelocatablePosition| is a helper class for keeping track of a |Position| in
a document upon DOM tree changes even if the given |Position|'s original
anchor node is moved out of document. The class is implemented by using a
temporary |Range| object to keep track of the |Position|, and disposing the
|Range| when out of scope.

|RelocatablePosition| will be used in editing code, for example:

https://codereview.chromium.org/2127503002/

BUG=n/a
TEST=webkit_unit_tests --gtest_filter=RelocatablePositionTest.position

Committed: https://crrev.com/485ff73a6daeed372189a91ff19edb88ebea18b0
Cr-Commit-Position: refs/heads/master@{#403878}
==========

[commit-bot: I haz the power, 2016-07-06 10:00:52]

Patchset 3 (id:??) landed as
https://crrev.com/485ff73a6daeed372189a91ff19edb88ebea18b0
Cr-Commit-Position: refs/heads/master@{#403878}