Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: third_party/WebKit/Source/wtf/Functional.h

Issue 2123883002: Remove tuple-related includes and comments in Functional.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/Functional.h
diff --git a/third_party/WebKit/Source/wtf/Functional.h b/third_party/WebKit/Source/wtf/Functional.h
index 800d068fdac0782899e508145e743df983d21341..c23fdc7ef54b4f9943bafff3c162db667f9cc85e 100644
--- a/third_party/WebKit/Source/wtf/Functional.h
+++ b/third_party/WebKit/Source/wtf/Functional.h
@@ -28,7 +28,6 @@
#include "base/bind.h"
#include "base/threading/thread_checker.h"
-#include "base/tuple.h"
#include "wtf/Allocator.h"
#include "wtf/Assertions.h"
#include "wtf/PassRefPtr.h"
@@ -37,7 +36,6 @@
#include "wtf/ThreadSafeRefCounted.h"
#include "wtf/TypeTraits.h"
#include "wtf/WeakPtr.h"
-#include <tuple>
#include <utility>
namespace blink {
@@ -248,10 +246,6 @@ private:
template <FunctionThreadAffinity threadAffinity, typename FunctionType, typename... BoundParameters>
std::unique_ptr<Function<base::MakeUnboundRunType<FunctionType, BoundParameters...>, threadAffinity>> bindInternal(FunctionType function, BoundParameters&&... boundParameters)
{
- // Bound parameters' types are wrapped with std::tuple so we can pass two template parameter packs (bound
- // parameters and unbound) to PartBoundFunctionImpl. Note that a tuple of this type isn't actually created;
- // std::tuple<> is just for carrying the bound parameters' types. Any other class template taking a type parameter
- // pack can be used instead of std::tuple. std::tuple is used just because it's most convenient for this purpose.
using UnboundRunType = base::MakeUnboundRunType<FunctionType, BoundParameters...>;
return wrapUnique(new Function<UnboundRunType, threadAffinity>(base::Bind(function, typename ParamStorageTraits<typename std::decay<BoundParameters>::type>::StorageType(std::forward<BoundParameters>(boundParameters))...)));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698