content/browser/BUILD.gn - Issue 2123863004: ScreenCapture for Android phase1, part II

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/BUILD.gn

Issue 2123863004: ScreenCapture for Android phase1, part II (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/BUILD.gn

diff --git a/content/browser/BUILD.gn b/content/browser/BUILD.gn

index d837e2405975b10f0d949d2ef05947d270e7a896..b40be7dca2db66961842fe0bdcee2929219e1552 100644

--- a/content/browser/BUILD.gn

+++ b/content/browser/BUILD.gn

@@ -196,7 +196,7 @@ source_set("browser") {

"//third_party/webrtc/media:rtc_media",

"//third_party/webrtc/modules/desktop_capture:primitives",

]

- if (is_linux || is_mac || is_win) {

+ if (is_linux || is_mac || is_win || is_android) {

Sergey Ulanov 2016/08/19 05:54:15 I think you want to keep this line as it was befor

braveyao 2016/08/23 21:18:54 Done. I suppose we still need to exclude ios, rig

sources += [

"media/capture/desktop_capture_device.cc",

Sergey Ulanov 2016/08/19 05:54:15 This class is not useful on android (because you a

braveyao 2016/08/23 21:18:54 Done.

"media/capture/desktop_capture_device.h",