Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: chrome/browser/media/permission_bubble_media_access_handler.cc

Issue 2123863004: ScreenCapture for Android phase1, part II (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/permission_bubble_media_access_handler.cc
diff --git a/chrome/browser/media/permission_bubble_media_access_handler.cc b/chrome/browser/media/permission_bubble_media_access_handler.cc
index 7a110159a58fe089002a84126791eff38e48ece4..020ad2023bfaf3f943995b3570ef39e99e1d57a8 100644
--- a/chrome/browser/media/permission_bubble_media_access_handler.cc
+++ b/chrome/browser/media/permission_bubble_media_access_handler.cc
@@ -6,6 +6,7 @@
#include <utility>
+#include "base/command_line.h"
#include "base/metrics/field_trial.h"
#include "chrome/browser/media/media_permission.h"
#include "chrome/browser/media/media_stream_device_permissions.h"
@@ -18,6 +19,7 @@
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/common/content_switches.h"
#if BUILDFLAG(ANDROID_JAVA_UI)
#include <vector>
@@ -77,8 +79,14 @@ PermissionBubbleMediaAccessHandler::~PermissionBubbleMediaAccessHandler() {
bool PermissionBubbleMediaAccessHandler::SupportsStreamType(
const content::MediaStreamType type,
const extensions::Extension* extension) {
+#if BUILDFLAG(ANDROID_JAVA_UI)
+ return type == content::MEDIA_DEVICE_VIDEO_CAPTURE ||
+ type == content::MEDIA_DEVICE_AUDIO_CAPTURE ||
+ type == content::MEDIA_DESKTOP_VIDEO_CAPTURE;
+#else
return type == content::MEDIA_DEVICE_VIDEO_CAPTURE ||
type == content::MEDIA_DEVICE_AUDIO_CAPTURE;
+#endif
}
bool PermissionBubbleMediaAccessHandler::CheckMediaAccessPermission(
@@ -106,6 +114,18 @@ void PermissionBubbleMediaAccessHandler::HandleRequest(
const extensions::Extension* extension) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
+#if BUILDFLAG(ANDROID_JAVA_UI)
+ if (request.video_type == content::MEDIA_DESKTOP_VIDEO_CAPTURE &&
+ !base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableUserMediaScreenCapturing)) {
+ // If screen capturing isn't enabled on Android, we'll use "invalid state"
+ // as result, same as on desktop.
+ callback.Run(content::MediaStreamDevices(),
+ content::MEDIA_DEVICE_INVALID_STATE, nullptr);
+ return;
+ }
+#endif
+
RequestsQueue& queue = pending_requests_[web_contents];
queue.push_back(PendingAccessRequest(request, callback));
@@ -134,7 +154,8 @@ void PermissionBubbleMediaAccessHandler::ProcessQueuedAccessRequest(
base::Bind(
&PermissionBubbleMediaAccessHandler::OnAccessRequestResponse,
base::Unretained(this), web_contents)));
- if (!controller->IsAskingForAudio() && !controller->IsAskingForVideo()) {
+ if (!controller->IsAskingForAudio() && !controller->IsAskingForVideo() &&
+ !controller->IsAskingForScreenCapture()) {
#if BUILDFLAG(ANDROID_JAVA_UI)
// If either audio or video was previously allowed and Chrome no longer has
// the necessary permissions, show a infobar to attempt to address this

Powered by Google App Engine
This is Rietveld 408576698