ScreenCapture for Android phase1, part II

chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManager.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.tabmodel;
 
 import android.app.Activity;
 import android.util.SparseArray;
 
 import org.chromium.base.ActivityState;
@@ skipping 139 matching lines @@
             Tab tab = asyncTabParams.valueAt(i).getTabToReparent();
             if (tab != null && tab.isIncognito()) count++;
         }
         return count;
     }
 
     /**
      * @param tabId The ID of the tab in question.
      * @return Whether the given tab exists in any currently loaded selector.
      */
     public boolean tabExistsInAnySelector(int tabId) {

[Ted C, 2016/08/16 00:19:19]

can you change this to be:

return getTabById(tabId) != null;

[braveyao, 2016/08/16 23:05:49]

Done.

And there is no easy way to test this line:
if (AsyncTabParamsManager.hasParamsForTabId(tabId)) {
  return AsyncTabParamsManager.getAsyncTabParams().get(tabId).getTabTo
     Reparent();
}
So the TabWindowManagerTest#testTabExistsInAnySelector has to be revised a bit.

         for (int i = 0; i < mSelectors.size(); i++) {
             TabModelSelector selector = mSelectors.get(i);
             if (selector != null) {
                 if (TabModelUtils.getTabById(selector.getModel(false), tabId) != null
                         || TabModelUtils.getTabById(selector.getModel(true), tabId) != null) {
                     return true;
                 }
             }
         }
 
         // Account for tabs that were recently reparented and haven't been attached to new
         // activities yet.
         return AsyncTabParamsManager.hasParamsForTabId(tabId);
     }
 
+    /**
+     * @param tabId The ID of the tab in question.
+     * @return Specified {@link Tab} or {@code null} if the {@link Tab} is not found.
+     */
+    public Tab getTabById(int tabId) {
+        for (int i = 0; i < mSelectors.size(); i++) {
+            TabModelSelector selector = mSelectors.get(i);
+            if (selector != null) {
+                final Tab tab = selector.getTabById(tabId);
+                if (tab != null) return tab;
+            }
+        }
+
+        if (AsyncTabParamsManager.hasParamsForTabId(tabId)) {
+            return AsyncTabParamsManager.getAsyncTabParams().get(tabId).getTabToReparent();
+        }
+
+        return null;
+    }
+
     @Override
     public void onActivityStateChange(Activity activity, int newState) {
         if (newState == ActivityState.DESTROYED && mAssignments.containsKey(activity)) {
             int index = mSelectors.indexOf(mAssignments.remove(activity));
             if (index >= 0) mSelectors.set(index, null);
             // TODO(dtrainor): Move TabModelSelector#destroy() calls here.
         }
     }
 
     /**
@@ skipping 14 matching lines @@
 
     private static class DefaultTabModelSelectorFactory implements TabModelSelectorFactory {
         @Override
         public TabModelSelector buildSelector(ChromeActivity activity, WindowAndroid windowAndroid,
                 int selectorIndex) {
             assert activity == windowAndroid.getActivity().get();
             return new TabModelSelectorImpl(activity, selectorIndex, windowAndroid);
         }
     }
 }