Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Issue 2123863003: Use early-return style in SpellChecker::spellCheckOldSelection() (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use early-return style in SpellChecker::spellCheckOldSelection() This patch makes |SpellChecker::spellCheckOldSelection()| to use early-return style to reduce indentation for improving readability. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/3f0ed597259306c8e939e15b571ad2bc8aa5aebf Cr-Commit-Position: refs/heads/master@{#404080}

Patch Set 1 : 2016-07-07T11:26:22 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-07 03:32:09 UTC) #3
Xiaocheng
lgtm
4 years, 5 months ago (2016-07-07 03:33:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123863003/1
4 years, 5 months ago (2016-07-07 04:00:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 05:05:11 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 05:07:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f0ed597259306c8e939e15b571ad2bc8aa5aebf
Cr-Commit-Position: refs/heads/master@{#404080}

Powered by Google App Engine
This is Rietveld 408576698