third_party/WebKit/Source/core/html/HTMLSelectElement.cpp - Issue 2123863002: Improve performance of HTMLSelectElement::deselectItemsWithoutValidation().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2123863002: Improve performance of HTMLSelectElement::deselectItemsWithoutValidation(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

index a2cca350f1509490173efa3c80d9cf4fb101e60e..214383c51b858d77499cb1c23072ba91aac1e185 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

@@ -1192,6 +1192,10 @@ void HTMLSelectElement::dispatchBlurEvent(Element* newFocusedElement, WebFocusTy

void HTMLSelectElement::deselectItemsWithoutValidation(HTMLElement* excludeElement)

{

+ if (!multiple() && usesMenuList() && m_lastOnChangeOption && m_lastOnChangeOption != excludeElement) {

+ m_lastOnChangeOption->setSelectedState(false);

+ return;

+ }

for (auto& element : listItems()) {

if (element != excludeElement && isHTMLOptionElement(*element))

toHTMLOptionElement(element)->setSelectedState(false);

« no previous file with comments | « no previous file | no next file » | no next file with comments »